Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: swap descriptions for [extname] and [ext] #2656

Merged
merged 1 commit into from Jan 19, 2019

Conversation

tivac
Copy link
Contributor

@tivac tivac commented Jan 15, 2019

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

While working on plugin stuff I noticed that I was using [extname] and seeing a leading period in the result, which the docs said I shouldn't. I went and looked at the rollup source for this functionality:

case 'extname':
return extname(asset.name);
case 'ext':
return extname(asset.name).substr(1);

Which sure makes it look like the docs were wrong. So I swapped [extname] and [ext] so now they line up correctly based on what they do.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Yes, extname was meant to match up with path.extname, got a little mixed up in the docs 🙄

@lukastaegert lukastaegert merged commit c1feb63 into rollup:master Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants