Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test stability #4878

Merged
merged 3 commits into from
Feb 25, 2023
Merged

Improve test stability #4878

merged 3 commits into from
Feb 25, 2023

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Lately, there have been a lot of test failures for watch-related CLI tests on MacOS. For now, this will slightly improve timeout handling and add a "retry" option to tests so that certain tests will be retried once before failing.
Of course this is only a stop-gap measure until we figure out why those tests fail, but this..

@netlify
Copy link

netlify bot commented Feb 25, 2023

Deploy Preview for rollupjs ready!

Name Link
🔨 Latest commit fe429c1
🔍 Latest deploy log https://app.netlify.com/sites/rollupjs/deploys/63fa614e1774e10008e1c7b1
😎 Deploy Preview https://deploy-preview-4878--rollupjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Feb 25, 2023

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#improve-test-stability

or load it into the REPL:
https://deploy-preview-4878--rollupjs.netlify.app/repl/?pr=4878

@codecov
Copy link

codecov bot commented Feb 25, 2023

Codecov Report

Merging #4878 (fe429c1) into master (a9de15d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4878   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         219      219           
  Lines        7945     7945           
  Branches     2189     2189           
=======================================
  Hits         7864     7864           
  Misses         26       26           
  Partials       55       55           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukastaegert lukastaegert merged commit 0e4d534 into master Feb 25, 2023
@lukastaegert lukastaegert deleted the improve-test-stability branch February 25, 2023 20:05
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.17.3. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants