-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experimental logging for side effects #4871
Conversation
✅ Deploy Preview for rollupjs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#fix-min-chunk-size-with-logging or load it into the REPL: |
873b226
to
b4fddb7
Compare
This PR has been released as part of rollup@3.17.3-0. Note that this is a pre-release, so to test it, you need to install Rollup via |
Codecov Report
@@ Coverage Diff @@
## master #4871 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 219 219
Lines 7948 7967 +19
Branches 2189 2193 +4
=======================================
+ Hits 7867 7886 +19
Misses 26 26
Partials 55 55
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This PR has been released as part of rollup@3.17.3-1. Note that this is a pre-release, so to test it, you need to install Rollup via |
22a7b4b
to
6dfc9c3
Compare
6dfc9c3
to
06c4036
Compare
91ff2e7
to
9c47ae7
Compare
9c47ae7
to
a4bb325
Compare
This PR has been released as part of rollup@3.18.0-0. Note that this is a pre-release, so to test it, you need to install Rollup via |
This PR has been released as part of rollup@3.18.0. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
This will add a new option
experimentalLogSideEffects: boolean
that will log the first side effect to that console that it finds in every input file. This can be very helpful for debugging. The output will contain a code-frame that roughly looks like this:In case a transformation with source maps changed the location, the log will be extended to contain that information as well:
This is just an experimental feature as "logging to the console" is probably not what we want in the long run. Once we have a proper logging mechanism that works similar to how warnings are handled at the moment, we can turn this into a proper feature.