-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: export loadConfigFile type #4853
feat: export loadConfigFile type #4853
Conversation
✅ Deploy Preview for rollupjs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## master #4853 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 219 219
Lines 7943 7943
Branches 2189 2188 -1
=======================================
Hits 7862 7862
Misses 26 26
Partials 55 55
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, that is exactly how I thought it should be done! One minor comment with regard to naming the build plugins, and I will need to do a little more testing to see if the types work correctly in all cases (but I trust they do).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks a lot!
This PR has been released as part of rollup@3.17.1. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
resolves #4841
Description