Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct import.meta.url slashes on Windows #4693

Merged
merged 5 commits into from Oct 31, 2022

Conversation

lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Oct 29, 2022

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Ensure that backslashes are converted to slashes when preserving modules. Ensure that filenames are properly escaped when using import.meta.url.

@lukastaegert lukastaegert marked this pull request as draft October 29, 2022 04:52
@github-actions
Copy link

github-actions bot commented Oct 29, 2022

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#import-meta-windows

or load it into the REPL:
https://rollupjs.org/repl/?pr=4693

@codecov
Copy link

codecov bot commented Oct 29, 2022

Codecov Report

Merging #4693 (bd2cd19) into master (f518bec) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4693   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files         215      215           
  Lines        7574     7574           
  Branches     2098     2098           
=======================================
  Hits         7500     7500           
  Misses         24       24           
  Partials       50       50           
Impacted Files Coverage Δ
src/ast/nodes/MetaProperty.ts 100.00% <ø> (ø)
src/Chunk.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukastaegert lukastaegert merged commit bac9826 into master Oct 31, 2022
@lukastaegert lukastaegert deleted the import-meta-windows branch October 31, 2022 19:12
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.2.4. You can test it via npm install rollup.

jerome-benoit added a commit to SAP/e-mobility-charging-stations-simulator that referenced this pull request Oct 31, 2022
Windows build should be fixed by rollup/rollup#4693

Signed-off-by: Jérôme Benoit <jerome.benoit@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v3.x.x] Windows build issue: Legacy octal escape sequences are not allowed in strict mode
2 participants