Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return correct values for unkown namespace members #4684

Merged
merged 1 commit into from Oct 18, 2022

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

For some reason, I assumed the logic to retrieve explicit values from namespaces would only be relevant for Symbol.toStringTag. No idea why I thought that, here is the fix.

@github-actions
Copy link

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-4680-unknown-namespace-value

or load it into the REPL:
https://rollupjs.org/repl/?pr=4684

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #4684 (acd6240) into master (1619ef2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4684   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files         215      215           
  Lines        7570     7572    +2     
  Branches     2096     2097    +1     
=======================================
+ Hits         7496     7498    +2     
  Misses         24       24           
  Partials       50       50           
Impacted Files Coverage Δ
src/ast/variables/NamespaceVariable.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukastaegert lukastaegert merged commit 088c877 into master Oct 18, 2022
@lukastaegert lukastaegert deleted the gh-4680-unknown-namespace-value branch October 18, 2022 04:34
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.2.3. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v3] treeshake unexpectedly assumed "a" in b==b.a != null
2 participants