Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not rewrite new.target #4679

Merged
merged 2 commits into from Oct 18, 2022
Merged

Do not rewrite new.target #4679

merged 2 commits into from Oct 18, 2022

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This adds checks to the MetaProperty handling to better distinguish import.meta from new.target and never rewrite the latter.

@github-actions
Copy link

github-actions bot commented Oct 17, 2022

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-4678-new-target

or load it into the REPL:
https://rollupjs.org/repl/?pr=4679

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #4679 (0a9206a) into master (088c877) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4679   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files         215      215           
  Lines        7572     7574    +2     
  Branches     2097     2098    +1     
=======================================
+ Hits         7498     7500    +2     
  Misses         24       24           
  Partials       50       50           
Impacted Files Coverage Δ
src/ast/nodes/MetaProperty.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukastaegert lukastaegert merged commit 63ed4fa into master Oct 18, 2022
@lukastaegert lukastaegert deleted the gh-4678-new-target branch October 18, 2022 04:50
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.2.3. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new.target is treated as import.meta
2 participants