Improve performance of chunk naming collision check #4643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4643 +/- ##
=======================================
Coverage 98.87% 98.87%
=======================================
Files 210 211 +1
Lines 7373 7384 +11
Branches 2106 2107 +1
=======================================
+ Hits 7290 7301 +11
Misses 27 27
Partials 56 56
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lukastaegert
force-pushed
the
master
branch
4 times, most recently
from
f47ff14
to
6ce8096
Compare
lukastaegert
force-pushed
the
gh-4642-faster-chunk-collision-check
branch
from
7d79b2f
to
8019a3a
Compare
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#gh-4642-faster-chunk-collision-checkor load it into the REPL: |
lukastaegert
force-pushed
the
master
branch
from
6ce8096
to
2477228
Compare
lukastaegert
force-pushed
the
gh-4642-faster-chunk-collision-check
branch
from
8019a3a
to
36e170e
Compare
lukastaegert
force-pushed
the
master
branch
from
2477228
to
dd2db8d
Compare
lukastaegert
force-pushed
the
gh-4642-faster-chunk-collision-check
branch
from
36e170e
to
59879fa
Compare
lukastaegert
force-pushed
the
master
branch
from
dd2db8d
to
eca6a6c
Compare
lukastaegert
force-pushed
the
gh-4642-faster-chunk-collision-check
branch
from
59879fa
to
6709adf
Compare
lukastaegert
force-pushed
the
master
branch
from
eca6a6c
to
71d20c9
Compare
lukastaegert
force-pushed
the
gh-4642-faster-chunk-collision-check
branch
from
6709adf
to
9fee6ab
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
When creating many chunks (> 1000), the name collision check for case-insensitive file systems was exploding, leading to terrible performance. This is solved by using a proxy to build a lower-case looking table for file names as the bundle is created.