Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test/form/samples/quote-id on Windows #4614

Merged
merged 1 commit into from Aug 23, 2022

Conversation

simonbuchan
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Don't know if this is the right fix?

Failure looks like:

  1) rollup
       form
         quote-id: handles escaping for external ids
           generates amd:

      AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected ... Lines skipped

  "define(['quoted\\'\\\r\\\n" +
+   "\\
\\
external1', './C:/code/others/rollup/test/form/samples/quote-id/quoted\\'\\\r\\\n" +
-   "\\
\\
external1', './quoted\\'\\\r\\\n" +
    "\\
\\
external2', './C:/File/Path'], (function (quoted_____external1, quoted_____external2, Path_js) { 'use strict';\n" +
...
    '\tconsole.log(quoted_____external1.foo, quoted_____external2.bar, Path_js.baz);\n' +
    '\n' +
    '}));'
      + expected - actual

\      define(['quoted\'\
\     -\
\
external1', './C:/code/others/rollup/test/form/samples/quote-id/quoted\'\
\     +\
\
external1', './quoted\'\
       \
\
external2', './C:/File/Path'], (function (quoted_____external1, quoted_____external2, Path_js) { 'use strict';

        console.log(quoted_____external1.foo, quoted_____external2.bar, Path_js.baz);


      at generateAndTestBundle (test\form\index.js:113:9)
      at runRollupTest (test\form\index.js:33:6)

@lukastaegert lukastaegert enabled auto-merge (squash) August 23, 2022 04:05
@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #4614 (897d0e3) into master (398d0c4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4614   +/-   ##
=======================================
  Coverage   98.87%   98.87%           
=======================================
  Files         209      209           
  Lines        7368     7368           
  Branches     2103     2103           
=======================================
  Hits         7285     7285           
  Misses         27       27           
  Partials       56       56           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukastaegert lukastaegert merged commit eb1fab7 into rollup:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants