Try to make logical expression deoptimization more robust #4519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#gh4517-improve-logical-expression-deoptimizationor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4519 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 208 209 +1
Lines 7432 7436 +4
Branches 2130 2130
=======================================
+ Hits 7341 7345 +4
Misses 32 32
Partials 59 59
Continue to review full report at Codecov.
|
Solves an issue where trying to render a non-included argument crashes
lukastaegert
force-pushed
the
gh4517-improve-logical-expression-deoptimization
branch
from
d164f9b
to
aea0df3
Compare
pos777
pushed a commit
to pos777/rollup
that referenced
this pull request
Jun 18, 2022
* Try to make logical expression deoptimization more robust * Share argument rendering logic between call and new expression Solves an issue where trying to render a non-included argument crashes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #4517
Description
Turns out that while unused arguments of new expressions were not included, they were still rendered, which was causing issues for certain types of arguments like logical expressions. This is fixed here. As a result, unused arguments of new expressions at the end of the call are now removed, just like unused arguments of call expressions.