Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link to node polyfill repo #4513

Merged
merged 1 commit into from May 28, 2022
Merged

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #4469
Resolves #4388
Resolves #4346
Resolves #4032

Description

This updates the links to the abandoned snowpackjs/rollup-plugin-polyfill-node and replaces it with the at least fundamentally maintained FredKSchott/rollup-plugin-polyfill-node. See linked issues.

@github-actions
Copy link

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#update-polyfill-repo-link

or load it into the REPL:
https://rollupjs.org/repl/?pr=4513

@codecov
Copy link

codecov bot commented May 28, 2022

Codecov Report

Merging #4513 (08e51da) into master (c1d6226) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4513   +/-   ##
=======================================
  Coverage   98.78%   98.78%           
=======================================
  Files         208      208           
  Lines        7431     7431           
  Branches     2120     2120           
=======================================
  Hits         7341     7341           
  Misses         34       34           
  Partials       56       56           
Impacted Files Coverage Δ
cli/run/batchWarnings.ts 99.18% <ø> (ø)
src/finalisers/shared/warnOnBuiltins.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1d6226...08e51da. Read the comment docs.

@lukastaegert lukastaegert merged commit 0226fb2 into master May 28, 2022
@lukastaegert lukastaegert deleted the update-polyfill-repo-link branch May 28, 2022 13:01
pos777 pushed a commit to pos777/rollup that referenced this pull request Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant