Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chor: feature: bugfix: Add Typescript 4.5 nodenext node12 module resolution support #4416

Conversation

frank-dspeed
Copy link
Contributor

Added Typescript 4.5+ Support for nodenext and node12 resolve it will not lookup typings

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

If we do not apply this changes users of Typescript 4.5 with moduleResolution nodenext and node12 will not be able to get typings

Added Typescript 4.5+ Support for nodenext and node12 resolve it will not lookup typings
@frank-dspeed frank-dspeed changed the title Add Typescript 4.5 nodenext node12 module resolution support chor: feature: bugfix: Add Typescript 4.5 nodenext node12 module resolution support Feb 21, 2022
@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #4416 (3973587) into master (69eb721) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4416   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         204      204           
  Lines        7319     7319           
  Branches     2081     2081           
=======================================
  Hits         7226     7226           
  Misses         34       34           
  Partials       59       59           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69eb721...3973587. Read the comment docs.

@lukastaegert
Copy link
Member

Where is this documented in the TypeScript docs? I could not find it in the TS 4.5 docs. All I could find is this issue which is not resolved: microsoft/TypeScript#33079
Unless there is something I overlooked, I would wait for this feature to be released in a stable TypeScript version.

@frank-dspeed
Copy link
Contributor Author

frank-dspeed commented Feb 21, 2022

@lukastaegert it is inside the current

Stable release | 4.5.4 / 13 December 2021

we did not documented that we assumed that people will understand it documentation is on the way but you can see that we do the changes all over

you can see it here it is in rxjs and many other popular repos also all plugins need that extra condition asap to be used with any project that uses moduleResolution nodenext or node12 from typescript ^4.5.0

rollup/plugins#1114 i issued that as first step to look how it gets adopted but out of my view i can not maintain or use the plugins repo it is full of stuff that is not compatible with edge stuff so i would need to setup a legacy env to run the repo tooling for the plugins...

it would help if you could apply that operation on all repos or let me create a single update for all plugins so that they are compatible

i can verify that the changes do work correct with current nightly in current vscode nightly and that it has no negativ effect on current and older nodejs versions at present

@lukastaegert
Copy link
Member

You should REALLY document such potentially breaking stuff up front, and inform people about in your release notes. I can merge it because it probably does not break stuff, but to me this looks like a process that should be improved.

@lukastaegert lukastaegert merged commit 2cca505 into rollup:master Feb 22, 2022
@frank-dspeed
Copy link
Contributor Author

@lukastaegert sure everything can always get improved thanks.

@frank-dspeed frank-dspeed deleted the add_types_condition_package_json branch February 22, 2022 11:16
@frank-dspeed
Copy link
Contributor Author

@lukastaegert microsoft/TypeScript#46454 the documentation will get updated so only the nightly users are at present facing this while all could use it because typescript had no ability to gate the feature at a diffrent place at present.

so the problems will not happen again when typescript implemented experimental features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants