Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort manual chunks generated via a function by name #4397

Merged
merged 2 commits into from Feb 10, 2022

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #4394

Description

If a manual chunk function is used, this enforces a sorting order of the generated manual chunks by chunk name to avoid e.g. unintended hash changes.

@github-actions
Copy link

github-actions bot commented Feb 10, 2022

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-4394-sort-manual-chunks

or load it into the REPL:
https://rollupjs.org/repl/?pr=4397

@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #4397 (e116fef) into master (5f4d04f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4397   +/-   ##
=======================================
  Coverage   98.72%   98.73%           
=======================================
  Files         204      204           
  Lines        7320     7325    +5     
  Branches     2080     2081    +1     
=======================================
+ Hits         7227     7232    +5     
  Misses         34       34           
  Partials       59       59           
Impacted Files Coverage Δ
src/Bundle.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f4d04f...e116fef. Read the comment docs.

@lukastaegert lukastaegert changed the title Sort manual chunks via functions are sorted by name Sort manual chunks generated via a function by name Feb 10, 2022
@lukastaegert lukastaegert merged commit 1738215 into master Feb 10, 2022
@lukastaegert lukastaegert deleted the gh-4394-sort-manual-chunks branch February 10, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chunk hash is changed by manualChunks even if not modify any module
1 participant