Create a shallow copy when returning meta from resolveId #4347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#copy-resolve-id-metaor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4347 +/- ##
=======================================
Coverage 98.43% 98.43%
=======================================
Files 206 206
Lines 7350 7350
Branches 2088 2088
=======================================
Hits 7235 7235
Misses 55 55
Partials 60 60
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
When returning a meta object from a resolveId hook, Rollup would use this object as the meta property of a module. As it turned out, this is not only inconsistent with the
loadandtransformhooks (where the object is merged shallowly) but also causes unexpected behaviour. E.g., the meta object returned from aresolveIdhook can not be safely reused for other modules. But more importantly, it is unsafe to cache the return value ofthis.resolveas the associatedmetaproperty can change later on. This is fixed here.The issue turned up in rollup/plugins#1038