Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further stabilize watch tests #4338

Merged
merged 1 commit into from Jan 4, 2022
Merged

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This is a follow-up to the previous PR that was merged to find solutions for the remaining issues. This time I repeat flaky tests in loops.

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#further-stabilize-watch-tests

or load it into the REPL:
https://rollupjs.org/repl/?pr=4338

@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #4338 (71df04a) into master (0ceee1d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4338   +/-   ##
=======================================
  Coverage   98.44%   98.44%           
=======================================
  Files         206      206           
  Lines        7353     7353           
  Branches     2089     2089           
=======================================
  Hits         7239     7239           
  Misses         55       55           
  Partials       59       59           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ceee1d...71df04a. Read the comment docs.

@lukastaegert lukastaegert force-pushed the further-stabilize-watch-tests branch 2 times, most recently from 6ea8335 to 3cd60da Compare January 4, 2022 07:04
@lukastaegert
Copy link
Member Author

Looks like adding a build delay to the watch events test helped a lot, will clean this up and merge it.

@lukastaegert lukastaegert merged commit cf53733 into master Jan 4, 2022
@lukastaegert lukastaegert deleted the further-stabilize-watch-tests branch January 4, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant