Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not watch unless --watch is specified explicitly #4335

Merged
merged 1 commit into from Jan 4, 2022

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #3967

Description

If someone specifies e.g. rollup --no-watch.clearScreen but not --watch, we should not watch.

@github-actions
Copy link

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-3967-fix-cli-watch

or load it into the REPL:
https://rollupjs.org/repl/?pr=4335

@codecov
Copy link

codecov bot commented Dec 31, 2021

Codecov Report

Merging #4335 (6a0bfb6) into master (7f55571) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4335   +/-   ##
=======================================
  Coverage   98.44%   98.44%           
=======================================
  Files         205      205           
  Lines        7314     7320    +6     
  Branches     2084     2085    +1     
=======================================
+ Hits         7200     7206    +6     
  Misses         55       55           
  Partials       59       59           
Impacted Files Coverage Δ
cli/run/index.ts 100.00% <100.00%> (ø)
src/utils/options/mergeOptions.ts 100.00% <100.00%> (ø)
src/utils/options/options.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f55571...6a0bfb6. Read the comment docs.

@lukastaegert lukastaegert merged commit ba7fc53 into master Jan 4, 2022
@lukastaegert lukastaegert deleted the gh-3967-fix-cli-watch branch January 4, 2022 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Including a watch configuration argument without --watch still enables watching
1 participant