Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused rollup-plugin-typescript ambient module types #4233

Merged
merged 3 commits into from Oct 1, 2021

Conversation

dnalborczyk
Copy link
Contributor

@dnalborczyk dnalborczyk commented Sep 30, 2021

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

missed this during the @rollup/plugin-typescript bump.

also fixed the return type of is_reference.

@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #4233 (6a9e41e) into master (b67ef30) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4233   +/-   ##
=======================================
  Coverage   98.39%   98.39%           
=======================================
  Files         203      203           
  Lines        7341     7341           
  Branches     2087     2087           
=======================================
  Hits         7223     7223           
  Misses         58       58           
  Partials       60       60           
Impacted Files Coverage Δ
src/ast/nodes/Identifier.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b67ef30...6a9e41e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants