Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle double reexports from external namespaces #4159

Merged
merged 1 commit into from Jun 30, 2021

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #4158

Description

This fixes an issue with the new logic that prefers local namespace reexports over external ones. Basically what was happening that the logic to detect cycles was preventing proper resolution of external namespace reexports if the reexports went over several steps.

@github-actions
Copy link

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-4158-double-reexport

or load it into the REPL:
https://rollupjs.org/repl/?pr=4159

@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #4159 (7080da6) into master (5e49df7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4159   +/-   ##
=======================================
  Coverage   98.28%   98.28%           
=======================================
  Files         201      201           
  Lines        7118     7125    +7     
  Branches     2084     2087    +3     
=======================================
+ Hits         6996     7003    +7     
  Misses         58       58           
  Partials       64       64           
Impacted Files Coverage Δ
src/Module.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e49df7...7080da6. Read the comment docs.

@lukastaegert lukastaegert merged commit 3277bbf into master Jun 30, 2021
@lukastaegert lukastaegert deleted the gh-4158-double-reexport branch June 30, 2021 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: 'xyz' is not exported by xyz when re-exporting twice
2 participants