New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use issue forms #4152
Use issue forms #4152
Conversation
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install tjenkinson/rollup#issue-form or load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4152 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 201 201
Lines 7118 7118
Branches 2084 2084
=======================================
Hits 6996 6996
Misses 58 58
Partials 64 64 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really cool, thanks a lot for making us aware and setting this up! I had only minor comments about the labels.json, otherwise this is really useful. Especially the required fields handling, and the automatically added labels also go a long way. I also like the "triage" label meaning nobody had a look at this :)
@@ -39,6 +39,8 @@ | |||
{ "name": "t⁴ ⋅ regression", "color": "#0052cc" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can actually remove the first two about incomplete/removed templates now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
People can still edit manually or use a blank template so they still might be useful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you are right
Wow this looks fantastic. Definitely will implement in the plugins repo this week. |
This PR contains:
Are tests included?
Breaking Changes?
Description
Update the issue templates to use issue forms instead. This feature was just released to beta.
No need for html comments anymore :)
Not sure if you want the auto labels or if they're the ones you want so feel free to edit them.
I created a test repo here if you want to see what it looks like.