Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clarifying note to PR template #4128

Merged
merged 1 commit into from Jun 8, 2021
Merged

Conversation

lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Jun 6, 2021

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This will add a comment to the PR template prompting collaborators to list resolved issues as resolves #<issue number> so that Github can auto-close the issues when the PR is merged.

@github-actions
Copy link

github-actions bot commented Jun 6, 2021

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#clarify-pr-template

or load it into the REPL:
https://rollupjs.org/repl/?pr=4128

@codecov
Copy link

codecov bot commented Jun 6, 2021

Codecov Report

Merging #4128 (3dc5851) into master (592b9fe) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4128   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files         201      201           
  Lines        7079     7079           
  Branches     2071     2071           
=======================================
  Hits         6946     6946           
  Misses         64       64           
  Partials       69       69           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 592b9fe...3dc5851. Read the comment docs.

@lukastaegert lukastaegert merged commit 26fd18c into master Jun 8, 2021
@lukastaegert lukastaegert deleted the clarify-pr-template branch June 8, 2021 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant