Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track access side effects when using object spread operator #4113

Merged
merged 3 commits into from May 29, 2021

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #4093

Description

This will additionally check for getter side effects when using the spread operator on an object.

@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@1dd8ba7). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4113   +/-   ##
=========================================
  Coverage          ?   98.11%           
=========================================
  Files             ?      201           
  Lines             ?     7061           
  Branches          ?     2064           
=========================================
  Hits              ?     6928           
  Misses            ?       64           
  Partials          ?       69           
Impacted Files Coverage Δ
src/ast/nodes/SpreadElement.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dd8ba7...855b37b. Read the comment docs.

@github-actions
Copy link

github-actions bot commented May 28, 2021

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-4093-object-spread-side-effect

or load it into the REPL:
https://rollupjs.org/repl/?pr=4113

@lukastaegert lukastaegert force-pushed the gh-4093-object-spread-side-effect branch from d2d3213 to 0ade205 Compare May 28, 2021 13:41
@lukastaegert lukastaegert merged commit 4eeef6e into master May 29, 2021
@lukastaegert lukastaegert deleted the gh-4093-object-spread-side-effect branch May 29, 2021 04:36
@stefcameron stefcameron mentioned this pull request Jun 1, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

treeshake bug: object spread side effects incorrectly dropped
1 participant