Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 fix: undefined deoptimizePath when the first element is empty string #4070

Merged
merged 3 commits into from May 15, 2021
Merged

Conversation

si3nloong
Copy link
Contributor

@si3nloong si3nloong commented May 6, 2021

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Resolves #4067

@github-actions
Copy link

github-actions bot commented May 6, 2021

Thank you for your contribution! 鉂わ笍

You can try out this pull request locally by installing Rollup via

npm install si3nloong/rollup#master

or load it into the REPL:
https://rollupjs.org/repl/?pr=4070

@lukastaegert
Copy link
Member

Thanks. Can you add a test that fails without the fix? That would be important to make future refactoring safer.

@codecov
Copy link

codecov bot commented May 7, 2021

Codecov Report

Merging #4070 (946beb3) into master (2bee261) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4070   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files         193      193           
  Lines        6818     6824    +6     
  Branches     2002     2006    +4     
=======================================
+ Hits         6647     6653    +6     
  Misses         84       84           
  Partials       87       87           
Impacted Files Coverage 螖
src/Graph.ts 100.00% <100.00%> (酶)
src/ast/variables/NamespaceVariable.ts 100.00% <100.00%> (酶)
src/utils/pureComments.ts 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update c40d206...946beb3. Read the comment docs.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a test that covers the original issue. This looks good from my side.

@lukastaegert lukastaegert merged commit 3acd536 into rollup:master May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property 'deoptimizePath' of undefined
2 participants