Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix REPL artefact branch reference #4045

Merged
merged 1 commit into from Apr 14, 2021
Merged

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Unfortunately due to the use of the pull_request_target, the REPL artefact for pull requests was built from the target branch and not from the PR branch. Hopefully this fixes it.

@github-actions
Copy link

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#repl-artefact-target

or load it into the REPL:
https://rollupjs.org/repl/?pr=4045

@lukastaegert lukastaegert merged commit ef807c9 into master Apr 14, 2021
@lukastaegert lukastaegert deleted the repl-artefact-target branch April 14, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant