Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail when returning null or undefined from an async options hook #4039

Merged
merged 1 commit into from Apr 10, 2021

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #4038

Description

Due to a missing await, async options hooks with false results were not handled correctly.

@github-actions
Copy link

github-actions bot commented Apr 10, 2021

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-4038-async-options-null

or load it into the REPL:
https://rollupjs.org/repl/?circleci=14933

@codecov
Copy link

codecov bot commented Apr 10, 2021

Codecov Report

Merging #4039 (7bb6839) into master (5a22c8a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4039   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files         192      192           
  Lines        6785     6785           
  Branches     1994     1994           
=======================================
  Hits         6614     6614           
  Misses         84       84           
  Partials       87       87           
Impacted Files Coverage Δ
src/rollup/rollup.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a22c8a...7bb6839. Read the comment docs.

@lukastaegert lukastaegert merged commit 6559f68 into master Apr 10, 2021
@lukastaegert lukastaegert deleted the gh-4038-async-options-null branch April 10, 2021 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

async options hook returning null blows up
1 participant