Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async options hook returning null blows up #4038

Closed
trhinehart-godaddy opened this issue Apr 9, 2021 · 1 comment · Fixed by #4039
Closed

async options hook returning null blows up #4038

trhinehart-godaddy opened this issue Apr 9, 2021 · 1 comment · Fixed by #4039

Comments

@trhinehart-godaddy
Copy link

Expected Behavior

returning null should not try to parse options

Actual Behavior

TypeError: Cannot read property 'context' of null

normalizeInputOptions eventually gets called with the returned null value, throwing the above error. Issue only happens when returning a Promise.
@trhinehart-godaddy trhinehart-godaddy mentioned this issue Apr 9, 2021
Open
@lukastaegert lukastaegert mentioned this issue Apr 10, 2021
Merged
9 tasks
@lukastaegert
Copy link
Member

Thanks for spotting, fix at #4039

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not fail when returning null or undefined from an async options hook rollup/rollup
2 participants
@lukastaegert @trhinehart-godaddy