Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly include functions with side effects from side-effect-free modules #3944

Merged
merged 1 commit into from Jan 31, 2021

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #3942

Description

There was an issue with the inclusion logic for variables in modules without side effects that is fixed here.

@lukastaegert lukastaegert force-pushed the gh-3942-side-effect-function-import branch from 638f1a8 to 0246d1f Compare January 31, 2021 07:08
@rollup-bot
Copy link
Collaborator

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-3942-side-effect-function-import

or load it into the REPL:
https://rollupjs.org/repl/?circleci=14121

@codecov
Copy link

codecov bot commented Jan 31, 2021

Codecov Report

Merging #3944 (0246d1f) into master (bc2bf95) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3944   +/-   ##
=======================================
  Coverage   97.18%   97.18%           
=======================================
  Files         188      188           
  Lines        6684     6685    +1     
  Branches     1946     1947    +1     
=======================================
+ Hits         6496     6497    +1     
  Misses         99       99           
  Partials       89       89           
Impacted Files Coverage Δ
src/ast/nodes/shared/Node.ts 100.00% <ø> (ø)
src/Module.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc2bf95...0246d1f. Read the comment docs.

@lukastaegert lukastaegert merged commit be2e06d into master Jan 31, 2021
@lukastaegert lukastaegert deleted the gh-3942-side-effect-function-import branch January 31, 2021 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 2.37 dead code elimination broken on Rambda ES curry
2 participants