Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate acorn import #3929

Merged
merged 1 commit into from Jan 20, 2021
Merged

Deduplicate acorn import #3929

merged 1 commit into from Jan 20, 2021

Conversation

lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Jan 20, 2021

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

When switching to latest rollup-plugin-node-resolve, we suddenly had two copies of acorn in the build as acorn does not use module in its export conditions. This fixes it, noticeably reducing file size again.

@rollup-bot
Copy link
Collaborator

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#deduplicate-acorn

or load it into the REPL:
https://rollupjs.org/repl/?circleci=14003

@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #3929 (c8722e3) into master (f051067) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3929   +/-   ##
=======================================
  Coverage   97.13%   97.13%           
=======================================
  Files         188      188           
  Lines        6669     6669           
  Branches     1940     1940           
=======================================
  Hits         6478     6478           
  Misses        101      101           
  Partials       90       90           
Impacted Files Coverage Δ
src/utils/options/normalizeInputOptions.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f051067...c8722e3. Read the comment docs.

@lukastaegert lukastaegert merged commit 1ca0404 into master Jan 20, 2021
@lukastaegert lukastaegert deleted the deduplicate-acorn branch January 20, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants