Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward bundle through watch error events #3909

Merged
merged 1 commit into from Dec 14, 2020

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

One oversight from the previous PR #3883 was that when a bundle was successfully created but writing the files threw an error, then there was no way to close the bundle.

This is fixed now: In such a situation, the error event will also contain a reference to the created bundle. And the CLI will make sure, that the bundle is closed.

@rollup-bot
Copy link
Collaborator

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#close-bundle-on-watch-generate-error

or load it into the REPL:
https://rollupjs.org/repl/?circleci=13856

@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #3909 (bc573a0) into master (add322c) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3909      +/-   ##
==========================================
- Coverage   97.08%   97.08%   -0.01%     
==========================================
  Files         187      187              
  Lines        6548     6546       -2     
  Branches     1904     1905       +1     
==========================================
- Hits         6357     6355       -2     
  Misses        101      101              
  Partials       90       90              
Impacted Files Coverage Δ
cli/run/watch-cli.ts 92.10% <100.00%> (+0.10%) ⬆️
src/watch/watch.ts 99.06% <100.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update add322c...bc573a0. Read the comment docs.

@lukastaegert lukastaegert merged commit 850d30a into master Dec 14, 2020
@lukastaegert lukastaegert deleted the close-bundle-on-watch-generate-error branch December 14, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants