Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert pattern to folder export #3898

Merged
merged 1 commit into from Dec 6, 2020
Merged

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Reverts #3896

Description

As I did not realize, #3896 was a breaking change as it prevented extension-less requires for nested files. This reverts this change.

@rollup-bot
Copy link
Collaborator

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#revert-exports-change

or load it into the REPL:
https://rollupjs.org/repl/?circleci=13792

@codecov
Copy link

codecov bot commented Dec 6, 2020

Codecov Report

Merging #3898 (5a25161) into master (8eafd72) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3898   +/-   ##
=======================================
  Coverage   97.07%   97.07%           
=======================================
  Files         187      187           
  Lines        6538     6538           
  Branches     1901     1901           
=======================================
  Hits         6347     6347           
  Misses        101      101           
  Partials       90       90           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8eafd72...5a25161. Read the comment docs.

@lukastaegert lukastaegert merged commit 6baf48a into master Dec 6, 2020
@lukastaegert lukastaegert deleted the revert-exports-change branch December 6, 2020 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants