Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add pull_request to windows github actions #3892

Merged
merged 1 commit into from Dec 1, 2020

Conversation

shellscape
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This response from a Github PM https://twitter.com/chrisrpatterson/status/1333434798916980736 suggests that the lack of pull_request in our Action config is contributing to our problem. I still think there's a bigger Github bugbear here, but after enabling the Windows checks as mandatory for PR merge, I think this change might get us to where we need to be (and is in line with the plugins repo config)

This response from a Github PM suggests that the lack of `pull_request` in our Action config is contributing to our problem. I still think there's a bigger Github bugbear here, but after enabling the Windows checks as mandatory for PR merge, I think this change might get us to where we need to be (and is in line with the plugins repo config)
@rollup-bot
Copy link
Collaborator

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#chore/actions/pull_request

or load it into the REPL:
https://rollupjs.org/repl/?circleci=13722

@codecov
Copy link

codecov bot commented Nov 30, 2020

Codecov Report

Merging #3892 (ca3cfbf) into master (96e44bb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3892   +/-   ##
=======================================
  Coverage   97.07%   97.07%           
=======================================
  Files         187      187           
  Lines        6539     6539           
  Branches     1901     1901           
=======================================
  Hits         6348     6348           
  Misses        101      101           
  Partials       90       90           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96e44bb...ca3cfbf. Read the comment docs.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, that would explain a lot!

@lukastaegert lukastaegert merged commit 9a30104 into master Dec 1, 2020
@lukastaegert lukastaegert deleted the chore/actions/pull_request branch December 1, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants