Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timedPlugin leaves unhandled promise rejections when hook throws #3876

Closed
gluck opened this issue Nov 23, 2020 · 1 comment · Fixed by #4004
Closed

timedPlugin leaves unhandled promise rejections when hook throws #3876

gluck opened this issue Nov 23, 2020 · 1 comment · Fixed by #4004

Comments

@gluck
Copy link
Contributor

gluck commented Nov 23, 2020

Expected Behavior

As the build error is catched, no promise rejection should be left uncaught

Actual Behavior

UnhandledPromiseRejectionWarning gets thrown/displayed

  • Removing perf: true fixes the issue.
  • The unhandled promise is here, replacing this line by result = result.then(...) also fixes the issue, not leaving the created promise hanging. I can PR if agreed.
@lukastaegert
Copy link
Member

Hi, sorry this issue got a little under the radar. Yes, a PR is welcome if you still want to give it a go.

gluck added a commit to gluck/rollup that referenced this issue Mar 19, 2021
@gluck
Fixed unhandled promise rejections rollup#3876
1597c97 
when perf mode is activated and a plugin hooks throws.
@gluck gluck mentioned this issue Mar 19, 2021
Merged
9 tasks
lukastaegert pushed a commit that referenced this issue Mar 20, 2021
@gluck
Fixed unhandled promise rejections #3876 (#4004)
dfa441c 
when perf mode is activated and a plugin hooks throws.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed unhandled promise rejections gluck/rollup
2 participants
@gluck @lukastaegert