Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also removeExtensionFromRelativeAmdId in UMD finaliser #3872

Merged
merged 2 commits into from Nov 18, 2020

Conversation

tjenkinson
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (updated existing)
  • no

Breaking Changes?

  • yes
  • no

Description

I noticed in the UMD finialiser the AMD ids are not run through removeExtensionFromRelativeAmdId when in the AMD one they are.

Should't they work the same way?

@codecov
Copy link

codecov bot commented Nov 15, 2020

Codecov Report

Merging #3872 (5abab3b) into master (4e0b887) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3872   +/-   ##
=======================================
  Coverage   97.07%   97.07%           
=======================================
  Files         184      185    +1     
  Lines        6523     6523           
  Branches     1889     1889           
=======================================
  Hits         6332     6332           
  Misses        101      101           
  Partials       90       90           
Impacted Files Coverage Δ
src/finalisers/amd.ts 100.00% <ø> (ø)
...alisers/shared/removeExtensionFromRelativeAmdId.ts 100.00% <100.00%> (ø)
src/finalisers/umd.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e0b887...5abab3b. Read the comment docs.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lukastaegert lukastaegert merged commit 8305279 into rollup:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants