Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose syntheticNamedExports to ModuleInfo #3847

Merged
merged 6 commits into from Nov 2, 2020

Conversation

Amareis
Copy link
Contributor

@Amareis Amareis commented Oct 30, 2020

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

In docs there is line about meta and syntheticNamedExports in ModuleInfo:
image

@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #3847 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3847      +/-   ##
==========================================
- Coverage   97.06%   97.06%   -0.01%     
==========================================
  Files         184      184              
  Lines        6518     6517       -1     
  Branches     1887     1887              
==========================================
- Hits         6327     6326       -1     
  Misses        101      101              
  Partials       90       90              
Impacted Files Coverage Δ
src/ExternalModule.ts 100.00% <ø> (ø)
src/Chunk.ts 100.00% <100.00%> (ø)
src/Module.ts 100.00% <100.00%> (ø)
src/ast/variables/NamespaceVariable.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b41e532...9856207. Read the comment docs.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I would consider aligning the handling of the property with moduleSideEffects and meta, though.

src/ExternalModule.ts Show resolved Hide resolved
src/Module.ts Outdated Show resolved Hide resolved
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks a lot!

@lukastaegert lukastaegert merged commit 9540051 into rollup:master Nov 2, 2020
@Amareis Amareis deleted the expose-sne branch November 2, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants