Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FAQ: I think it was meant "external" instead of "other-entry.js" #3756

Merged
merged 2 commits into from Sep 1, 2020

Conversation

madacol
Copy link
Contributor

@madacol madacol commented Sep 1, 2020

external is the one imported twice in main.js and later in other-entry.js

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

In the question Why do additional imports turn up in my entry chunks when code-splitting? it was stated

With this optimization, a JavaScript engine will discover all transitive dependencies after parsing an entry module, avoiding the waterfall:

  1. Load and parse main.js. At the end, imports to other-entry.js and external will be discovered.
  2. Load and parse other-entry.js and external. The import of other-entry.js is already loaded and parsed.
  3. Execute main.js.

In line 2 it should say "The import of external is already loaded and parsed" because other-entry.js is the one that imports external

`external` is the one imported twice in `main.js` and later in `other-entry.js`
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #3756 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3756   +/-   ##
=======================================
  Coverage   97.02%   97.02%           
=======================================
  Files         185      185           
  Lines        6461     6461           
  Branches     1868     1868           
=======================================
  Hits         6269     6269           
  Misses        101      101           
  Partials       91       91           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a5a638...a1fcb97. Read the comment docs.

docs/06-faqs.md Outdated Show resolved Hide resolved
Co-authored-by: Lukas Taegert-Atkinson <lukastaegert@users.noreply.github.com>
@lukastaegert lukastaegert merged commit 426c076 into rollup:master Sep 1, 2020
@madacol madacol deleted the patch-1 branch September 1, 2020 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants