Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid variable name conflict when reexporting several namespaces from a chunk #3742

Merged
merged 1 commit into from Aug 22, 2020

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #3741

Description

The problem was that an optimization meant for preserveModules was also applied in all other cases where it did not make sense and was indeed harmful.

@rollup-bot
Copy link
Collaborator

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-3741-namespace-name-conflict

or load it into the REPL:
https://rollupjs.org/repl/?circleci=12697

@codecov
Copy link

codecov bot commented Aug 22, 2020

Codecov Report

Merging #3742 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3742   +/-   ##
=======================================
  Coverage   96.99%   96.99%           
=======================================
  Files         184      184           
  Lines        6452     6453    +1     
  Branches     1872     1873    +1     
=======================================
+ Hits         6258     6259    +1     
  Misses        103      103           
  Partials       91       91           
Impacted Files Coverage Δ
src/utils/deconflictChunk.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fada4f6...23e1758. Read the comment docs.

@lukastaegert lukastaegert merged commit 9096087 into master Aug 22, 2020
@lukastaegert lukastaegert deleted the gh-3741-namespace-name-conflict branch August 22, 2020 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Namespace reexports + code split result in variable conflict imports
2 participants