Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unintended ASI for nested conditionals #3732

Merged
merged 1 commit into from Aug 16, 2020

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #3729

Description

Apparently, the flag to prevent ASI-related issues was not correctly passed to nested expressions. This is fixed now, and also fixes this issue for yield expressions.

@rollup-bot
Copy link
Collaborator

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-3729-invalid-conditional-ASI

or load it into the REPL:
https://rollupjs.org/repl/?circleci=12632

@codecov
Copy link

codecov bot commented Aug 16, 2020

Codecov Report

Merging #3732 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3732   +/-   ##
=======================================
  Coverage   96.98%   96.98%           
=======================================
  Files         184      184           
  Lines        6431     6431           
  Branches     1862     1862           
=======================================
  Hits         6237     6237           
  Misses        103      103           
  Partials       91       91           
Impacted Files Coverage Δ
src/ast/nodes/ConditionalExpression.ts 96.34% <ø> (ø)
src/ast/nodes/LogicalExpression.ts 98.75% <ø> (ø)
src/ast/nodes/YieldExpression.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b432dc...1e52bdb. Read the comment docs.

@lukastaegert lukastaegert merged commit 57ed7e3 into master Aug 16, 2020
@lukastaegert lukastaegert deleted the gh-3729-invalid-conditional-ASI branch August 16, 2020 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid dead code removal for return statement due to ASI
2 participants