Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing variables for UMD and IIFE builds #3724

Merged
merged 1 commit into from Aug 15, 2020

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #3723

Description

There was a rendering issue that was not popping up in tests due to an interaction between different builds, which is fixed here.

@rollup-bot
Copy link
Collaborator

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-3723-missing-umd-variables

or load it into the REPL:
https://rollupjs.org/repl/?circleci=12562

@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #3724 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3724   +/-   ##
=======================================
  Coverage   96.97%   96.97%           
=======================================
  Files         184      184           
  Lines        6408     6409    +1     
  Branches     1855     1856    +1     
=======================================
+ Hits         6214     6215    +1     
  Misses        103      103           
  Partials       91       91           
Impacted Files Coverage Δ
src/Chunk.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13f18ef...6c2a90e. Read the comment docs.

@lukastaegert lukastaegert merged commit 42d2dfa into master Aug 15, 2020
@lukastaegert lukastaegert deleted the gh-3723-missing-umd-variables branch August 15, 2020 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollup 2.24 breaks UMD bundle
2 participants