-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend UMD loader to use globalThis #3666
Comments
What are environments that support neither So what is your use case, i.e. the environment that requires that and does not work with the existing wrapper? |
@lukastaegert I agree the environments are GraalJS, Deno while deno will probally fix that via bundling inside parcel but for beeing technical correct i think this is the right step todo as all new environments will use globalThis and it works in browsers and node so i think this is the way to go as it is the standard for exact that problem |
I believe #3691 would fix this sufficiently? |
@lukastaegert it looks like for me at last i did only execute the code in my head but i think it does at last the most importent thing. All Tests that i did execute in my head did pass so LGTM+1 for #3691 |
Expected Behavior / Situation
Actual Behavior / Situation
Modification Proposal
(function (global, factory) {
typeof exports === 'object' && typeof module !== 'undefined' ? module.exports = factory() :
typeof define === 'function' && define.amd ? define(factory) :
/**
(global = global || self, global.myBundle = factory());
needs refactor
*/
}(this, (function () { 'use strict';
/ code */
})));
The text was updated successfully, but these errors were encountered: