New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support numeric separator #3626
Conversation
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via
or load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #3626 +/- ##
=======================================
Coverage 96.54% 96.54%
=======================================
Files 182 182
Lines 6243 6243
Branches 1832 1832
=======================================
Hits 6027 6027
Misses 107 107
Partials 109 109
Continue to review full report at Codecov.
|
Works like a charm! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to include this by default.
33d3060
to
5f974c2
Compare
Why license is changed so drastically on npm install? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why license is changed so drastically on npm install?
It is generated differently when done via npm install
and npm ci
. I prefer the npm ci
version as the repos are more concise.
I took the liberty of also adding a small test. Looks fine otherwise.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers: #3605
Description
Node already supports numeric separators and using babel target "node: current" breaks rollup.