Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support numeric separator #3626

Merged
merged 4 commits into from Jun 12, 2020
Merged

Support numeric separator #3626

merged 4 commits into from Jun 12, 2020

Conversation

TrySound
Copy link
Member

@TrySound TrySound commented Jun 9, 2020

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers: #3605

Description

Node already supports numeric separators and using babel target "node: current" breaks rollup.

@rollup-bot
Copy link
Collaborator

rollup-bot commented Jun 9, 2020

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#numeric-separator

or load it into the REPL:
https://rollupjs.org/repl/?circleci=11878

@codecov
Copy link

codecov bot commented Jun 9, 2020

Codecov Report

Merging #3626 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3626   +/-   ##
=======================================
  Coverage   96.54%   96.54%           
=======================================
  Files         182      182           
  Lines        6243     6243           
  Branches     1832     1832           
=======================================
  Hits         6027     6027           
  Misses        107      107           
  Partials      109      109           
Impacted Files Coverage Δ
src/utils/options/normalizeInputOptions.ts 98.05% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 872e9e2...605ef19. Read the comment docs.

@TrySound
Copy link
Member Author

TrySound commented Jun 9, 2020

Works like a charm!

Copy link
Contributor

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to include this by default.

@TrySound
Copy link
Member Author

Why license is changed so drastically on npm install?

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why license is changed so drastically on npm install?

It is generated differently when done via npm install and npm ci. I prefer the npm ci version as the repos are more concise.

I took the liberty of also adding a small test. Looks fine otherwise.

@lukastaegert lukastaegert merged commit bacfcbe into master Jun 12, 2020
@lukastaegert lukastaegert deleted the numeric-separator branch June 12, 2020 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants