Observe side-effects in second argument of Array.from

[lukastaegert]

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

List any relevant issue numbers:
resolves #3603

Description

Apparently Array.from can have a second argument with side-effects. Unfortunately, this will now mark any call to Array.from as having side-effects as the global logic does not support anything better yet, but at least it should fix the provided issue. In the future, we might be able to do better.

[rollup-bot]

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-3603-array-from-side-effect

or load it into the REPL:
https://rollupjs.org/repl/?circleci=11487

[codecov]

Codecov Report

Merging #3604 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3604   +/-   ##
=======================================
  Coverage   96.35%   96.35%           
=======================================
  Files         180      180           
  Lines        6151     6151           
  Branches     1808     1808           
=======================================
  Hits         5927     5927           
  Misses        111      111           
  Partials      113      113           

Impacted Files	Coverage Δ
src/ModuleLoader.ts	100.00% <ø> (ø)
src/ast/nodes/shared/knownGlobals.ts	100.00% <ø> (ø)
src/Chunk.ts	99.79% <100.00%> (ø)
src/Module.ts	98.90% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 085cfc9...52b5c62. Read the comment docs.