Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treeshake prototype modifications in classes #3598

Merged
merged 2 commits into from May 27, 2020

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #3587

Description

This will apply similar logic to classes as to functions so that adding a property to the prototype of an unused class does not count as a side-effect.

@rollup-bot
Copy link
Collaborator

rollup-bot commented May 27, 2020

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-3587-treeshake-class-prototype-modifications

or load it into the REPL:
https://rollupjs.org/repl/?circleci=11434

@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #3598 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3598   +/-   ##
=======================================
  Coverage   96.35%   96.35%           
=======================================
  Files         180      180           
  Lines        6145     6147    +2     
  Branches     1801     1805    +4     
=======================================
+ Hits         5921     5923    +2     
  Misses        111      111           
  Partials      113      113           
Impacted Files Coverage Δ
src/ast/nodes/shared/ClassNode.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2a85a1...7e47a15. Read the comment docs.

@lukastaegert lukastaegert merged commit eb6ce17 into master May 27, 2020
@lukastaegert lukastaegert deleted the gh-3587-treeshake-class-prototype-modifications branch May 27, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add prototype as a known property to classes
2 participants