System format optional setters #3592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via or load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #3592 +/- ##
=======================================
Coverage 96.35% 96.35%
=======================================
Files 180 180
Lines 6147 6149 +2
Branches 1805 1807 +2
=======================================
+ Hits 5923 5925 +2
Misses 111 111
Partials 113 113
Continue to review full report at Codecov.
|
lukastaegert
force-pushed
the
system-optional-setter
branch
from
35890af
to
a7c244a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
For SystemJS users, when using dependency inlining there are a large number of dependencies that don't have a corresponding setter. Currently we output a whole bunch of empty functions for each of these empty setters which seems unnecessary.
This PR allows a new option to output
nullinstead of a completefunction () {}for each of these setters.It is only going to be supported in the next SystemJS hence why it needs an option. Eventually we can make this the default though.