Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target Node.js v14 instead of v13 #3585

Merged
merged 2 commits into from May 23, 2020
Merged

Target Node.js v14 instead of v13 #3585

merged 2 commits into from May 23, 2020

Conversation

mangs
Copy link
Contributor

@mangs mangs commented May 22, 2020

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This is my first contribution. I'm adding GitHub actions at my job, and I figured I would investigate how Rollup does it; in turn, I noticed this potential oversight.

Because Node.js v13 has been superseded by v14 with the intention to make the latter an LTS version, builds should target the eventual LTS version.

@codecov
Copy link

codecov bot commented May 23, 2020

Codecov Report

Merging #3585 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3585   +/-   ##
=======================================
  Coverage   96.30%   96.30%           
=======================================
  Files         177      177           
  Lines        6065     6065           
  Branches     1786     1786           
=======================================
  Hits         5841     5841           
  Misses        112      112           
  Partials      112      112           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f74198...dfc8b1e. Read the comment docs.

@lukastaegert lukastaegert merged commit 40b879b into rollup:master May 23, 2020
@mangs mangs deleted the patch-1 branch May 23, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants