Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure UnknownFooExpressions are included when referenced as return values in a MultiExpression #3559

Merged
merged 1 commit into from May 15, 2020

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #3555

Description

Apparently when using a return value of a function that contained conditional expressions and builtin methods, later mutations of that return value would not be tracked properly. This is fixed here. See the examples at #3555.

@rollup-bot
Copy link
Collaborator

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-3555-include-virtual-multi-expressions

or load it into the REPL:
https://rollupjs.org/repl/?circleci=11080

@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #3559 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3559   +/-   ##
=======================================
  Coverage   96.29%   96.29%           
=======================================
  Files         176      176           
  Lines        6049     6052    +3     
  Branches     1784     1785    +1     
=======================================
+ Hits         5825     5828    +3     
  Misses        112      112           
  Partials      112      112           
Impacted Files Coverage Δ
src/ast/nodes/shared/MultiExpression.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5872b0...2359754. Read the comment docs.

@lukastaegert lukastaegert merged commit 4ae97b5 into master May 15, 2020
@lukastaegert lukastaegert deleted the gh-3555-include-virtual-multi-expressions branch May 15, 2020 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improper DCE after seemingly-unrelated change
2 participants