Fix and improve default export alias logic #3521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via or load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #3521 +/- ##
==========================================
+ Coverage 96.12% 96.22% +0.09%
==========================================
Files 176 176
Lines 5984 5982 -2
Branches 1762 1763 +1
==========================================
+ Hits 5752 5756 +4
+ Misses 118 112 -6
Partials 114 114
Continue to review full report at Codecov.
|
lukastaegert
force-pushed
the
gh-3517-wrong-preserve-modules-variable-name
branch
from
6a501af
to
c513681
Compare
lukastaegert
force-pushed
the
gh-3517-wrong-preserve-modules-variable-name
branch
from
c513681
to
6fda3b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #3517
Description
This will fix an issue in the logic that identified certain types of default exports, e.g.
export default foo, with the variables they were exporting, e.g.foo. This caused wrong variable names and unnecessarily complex code in some cases.