Make sure labels are always included when not tree-shaking

[lukastaegert]

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

List any relevant issue numbers:
Resolves #3473

Description

This PR makes sure

• labels are always included when not tree-shaking
• Rollup uses a fresh inclusion context when including the declaration of a variable. This alone was the culprit of Label being incorrectly removed with treeshaking disabled #3473 and fixes it, but I thought I add the first point for completeness.

[rollup-bot]

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-3473-always-include-labels

or load it into the REPL:
https://rollupjs.org/repl/?circleci=10438

[codecov]

Codecov Report

Merging #3492 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3492      +/-   ##
==========================================
+ Coverage   95.94%   95.96%   +0.01%     
==========================================
  Files         174      174              
  Lines        5950     5947       -3     
  Branches     1752     1752              
==========================================
- Hits         5709     5707       -2     
+ Misses        124      123       -1     
  Partials      117      117              

Impacted Files	Coverage Δ
src/ast/variables/Variable.ts	100.00% <ø> (+4.16%)	⬆️
src/Chunk.ts	99.78% <100.00%> (-0.01%)	⬇️
src/Module.ts	98.86% <100.00%> (-0.01%)	⬇️
src/ast/nodes/BreakStatement.ts	100.00% <100.00%> (ø)
src/ast/nodes/ContinueStatement.ts	100.00% <100.00%> (ø)
src/ast/nodes/ExportDefaultDeclaration.ts	96.55% <100.00%> (ø)
src/ast/nodes/Identifier.ts	100.00% <100.00%> (ø)
src/ast/nodes/LabeledStatement.ts	100.00% <100.00%> (ø)
src/ast/nodes/MemberExpression.ts	98.27% <100.00%> (ø)
src/ast/nodes/shared/FunctionNode.ts	100.00% <100.00%> (ø)
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 027e1e5...1aa6f1a. Read the comment docs.

[guybedford]

Amazing, thanks for tracking this one down. Complete edge case I know, but hope the other fix was useful too.

[lukastaegert]

It was also a potential source for future problems