feat(watch): add skipWrite option
#3454
Conversation
| ``` | ||
| rollup -i input.js -f es -p ./my-plugin.js | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Sorry, these look to be my editor's auto-trimming
| @@ -1096,6 +1096,13 @@ Default: `true` | |||
|
|
|||
| Whether to clear the screen when a rebuild is triggered. | |||
|
|
|||
| #### watch.skipWrite | |||
| Type: `boolean`<br> | |||
| <!-- CLI: `--watch.skipWrite`<br> --> | |||
There was a problem hiding this comment.
This CLI option will work, but I figure it's better not to list it (similar to watch.chokidar) since its application makes zero sense via the CLI layer.
Codecov Report
@@ Coverage Diff @@
## master #3454 +/- ##
==========================================
+ Coverage 95.02% 95.02% +<.01%
==========================================
Files 171 171
Lines 5851 5852 +1
Branches 1726 1727 +1
==========================================
+ Hits 5560 5561 +1
Misses 157 157
Partials 134 134
Continue to review full report at Codecov.
|
| @@ -174,7 +176,7 @@ export class Task { | |||
| return; | |||
| } | |||
| this.updateWatchedFiles(result); | |||
| await Promise.all(this.outputs.map(output => result.write(output))); | |||
| this.skipWrite || (await Promise.all(this.outputs.map(output => result.write(output)))); | |||
There was a problem hiding this comment.
This is where the new option is applied.
(Not a fan of how the linter formatted it)
|
Nice. This I need to get my hands on the return value from
Is there anything I can do to help get this ready for release? |
|
Thanks! |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers: #3225
Description
This change allows programmatic
rollup.watchusers to opt out of automaticbundle.writecalls. This definitely won't be the common use case, but it's been requested (a few times) in the past for certain scenarios.