Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to avoid hoisting transitive imports #3353

Merged
merged 3 commits into from Jan 27, 2020

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #3062

Description

This will add an output option hoistTransitiveImports that can be set to false to avoid hoisting imports of chunk dependencies into entry chunks as "empty" imports. Also adds some documentation as to why this happens by default.

@codecov
Copy link

codecov bot commented Jan 26, 2020

Codecov Report

Merging #3353 into master will increase coverage by 0.02%.
The diff coverage is 98.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3353      +/-   ##
==========================================
+ Coverage   93.23%   93.26%   +0.02%     
==========================================
  Files         172      172              
  Lines        6048     6072      +24     
  Branches     1804     1809       +5     
==========================================
+ Hits         5639     5663      +24     
  Misses        218      218              
  Partials      191      191
Impacted Files Coverage Δ
src/utils/entryHashing.ts 100% <100%> (ø) ⬆️
src/utils/chunkColouring.ts 98.36% <98.33%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f72e5f...8b300ed. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to turn off the "avoiding the waterfall" feature
1 participant