Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test file names, update dependencies #3342

Merged
merged 1 commit into from Jan 18, 2020
Merged

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

At the moment, Windows tests are no longer running because Github actions do not want to check out files names containing ":". I changed the corresponding test (as it was not the most central part of this test) and also updated all dependencies.

@lukastaegert lukastaegert changed the title Remove test file names, update dependencies Fix test file names, update dependencies Jan 18, 2020
@codecov
Copy link

codecov bot commented Jan 18, 2020

Codecov Report

Merging #3342 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3342   +/-   ##
=======================================
  Coverage   93.22%   93.22%           
=======================================
  Files         172      172           
  Lines        6038     6038           
  Branches     1800     1800           
=======================================
  Hits         5629     5629           
  Misses        218      218           
  Partials      191      191

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ab73c1...87586df. Read the comment docs.

@NfNitLoop
Copy link
Contributor

Hi @lukastaegert! I've been investigating a bug with generated file paths on Windows, and I think the tests that were failing here were telling you something important: : isn't valid in file names on Windows. That character should probably be added to the list in sanitizeFileName() (See details in the case I link above.)

I'm going to try to write a unit test and fix for this, but I'm new to NPM and Rollup, so it's going to take me a while. I'm happy to let someone more experienced bang out the fix if that's easier. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants