Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ! to assert not-null in typescript #3303

Merged
merged 1 commit into from Dec 25, 2019
Merged

Use ! to assert not-null in typescript #3303

merged 1 commit into from Dec 25, 2019

Conversation

NotWoods
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Replace casts from T | undefined to T with the ! operator.

@shellscape
Copy link
Contributor

@NotWoods LGTM but failing analysis.

@codecov
Copy link

codecov bot commented Dec 25, 2019

Codecov Report

Merging #3303 into master will decrease coverage by <.01%.
The diff coverage is 95.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3303      +/-   ##
==========================================
- Coverage   93.12%   93.12%   -0.01%     
==========================================
  Files         170      170              
  Lines        5967     5966       -1     
  Branches     1780     1781       +1     
==========================================
- Hits         5557     5556       -1     
  Misses        219      219              
  Partials      191      191
Impacted Files Coverage Δ
src/finalisers/shared/getExportBlock.ts 100% <ø> (ø) ⬆️
src/finalisers/amd.ts 97.14% <ø> (ø) ⬆️
browser/path.ts 76.92% <ø> (ø) ⬆️
src/utils/collapseSourcemaps.ts 90% <ø> (ø) ⬆️
src/finalisers/shared/setupNamespace.ts 90% <ø> (ø) ⬆️
src/finalisers/cjs.ts 97.43% <ø> (ø) ⬆️
src/ast/nodes/ExportAllDeclaration.ts 100% <100%> (ø) ⬆️
src/ast/variables/LocalVariable.ts 89.01% <100%> (ø) ⬆️
src/ast/values.ts 62.09% <100%> (ø) ⬆️
src/ast/nodes/CallExpression.ts 98.16% <100%> (ø) ⬆️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5a3f16...b40910d. Read the comment docs.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants